From c3d8a211ed1aea48f0610d7a13e5b35ebe4af02f Mon Sep 17 00:00:00 2001
From: xinatorus <patrik.sztefek@seznam.cz>
Date: Fri, 15 May 2020 20:59:12 +0200
Subject: [PATCH] rooms api

---
 app/api/RoomsApi.php                     | 36 +++++++++---------------
 app/models/managers/RoomManager.php      |  5 ++++
 app/models/managers/SubDeviceManager.php | 23 +++++++++++++++
 3 files changed, 41 insertions(+), 23 deletions(-)

diff --git a/app/api/RoomsApi.php b/app/api/RoomsApi.php
index 37fb285..340f09d 100644
--- a/app/api/RoomsApi.php
+++ b/app/api/RoomsApi.php
@@ -4,33 +4,23 @@ class RoomsApi extends ApiController{
 
 	public function default(){
 		//$this->requireAuth();
-		$rooms = [];
-		$roomsData = RoomManager::getAllRooms();
-		foreach ($roomsData as $roomKey => $roomData) {
-			$widgets = [];
-			$devicesData = DeviceManager::getAllDevicesInRoom($roomData['room_id']);
-			foreach ($devicesData as $deviceKey => $deviceData) {
-				$subDevicesData = SubDeviceManager::getAllSubDevices($deviceData['device_id']);
-				foreach ($subDevicesData as $subDeviceKey => $subDeviceData) {
-					$lastRecord = RecordManager::getLastRecord($subDeviceData['subdevice_id']);
-					$widgets[] = [
-						'subdevice_id' => $subDeviceData['subdevice_id'],
-						'device_id' =>  $deviceData['device_id'],
-						'name' => $deviceData['name'],
-						'type' => $subDeviceData['type'],
-						'icon' => $deviceData['icon'],
-						'value' => $lastRecord['value'],
-						'unit' => $subDeviceData['unit'],
-					];
-				}
-			}
+		$response = [];
+		$roomIds = [];
+		$roomsData = RoomManager::getRoomsDefault();
 
-			$rooms[] = [
+		foreach ($roomsData as $roomKey => $room) {
+			$roomIds[] = $room['room_id'];
+		}
+
+		$subDevicesData = SubDeviceManager::getSubdevicesByRoomIds($roomIds);
+
+		foreach ($roomsData as $roomKey => $roomData) {
+			$response[] = [
 				'room_id' => $roomData['room_id'],
 				'name' => $roomData['name'],
-				'widgets' => $widgets,
+				'widgets' => isset($subDevicesData[$roomData['room_id']]) ? $subDevicesData[$roomData['room_id']] : [],
 			];
 		}
-		$this->response($rooms);
+		$this->response($response);
 	}
 }
diff --git a/app/models/managers/RoomManager.php b/app/models/managers/RoomManager.php
index 928b829..795ee79 100644
--- a/app/models/managers/RoomManager.php
+++ b/app/models/managers/RoomManager.php
@@ -12,6 +12,11 @@ class RoomManager{
 		return $allRoom;
 	}
 
+	static function getRoomsDefault () {
+		$allRoom = Db::loadAll ("SELECT room_id, name FROM rooms");
+		return $allRoom;
+	}
+
 	public static function create ($name) {
 		$room = array (
 			'name' => $name,
diff --git a/app/models/managers/SubDeviceManager.php b/app/models/managers/SubDeviceManager.php
index edcca33..712db1d 100644
--- a/app/models/managers/SubDeviceManager.php
+++ b/app/models/managers/SubDeviceManager.php
@@ -71,4 +71,27 @@ class SubDeviceManager
 		RecordManager::cleanSubdeviceRecords($subDeviceId);
 		return Db::loadAll("DELETE FROM subdevices WHERE subdevice_id = ?", array($subDeviceId));
 	}
+
+	public static function getSubdevicesByRoomIds($roomIds = NULL) {
+		if(empty($roomIds)) return NULL;
+
+		$rows = Db::loadAll("
+			SELECT d.room_id, sd.subdevice_id, sd.device_id, d.name, sd.type, sd.unit, r.value FROM subdevices sd
+			JOIN devices d ON sd.device_id = d.device_id
+			JOIN records r ON r.subdevice_id = sd.subdevice_id
+			WHERE d.room_id IN (".str_repeat("?,", count($roomIds)-1)."?)
+			AND r.record_id IN (
+				SELECT MAX(record_id)
+				FROM records
+				GROUP BY subdevice_id
+		  	)
+		", $roomIds);
+
+		$ret = [];
+		foreach($rows as $row){
+			$ret[$row['room_id']][] = $row;
+		}
+
+		return $ret;
+	}
 }